This Might Be A Wiki:MediaWiki 1.22 Upgrade

Use this page to report issues associated with the upgrade of the wiki software from 1.20.3 to 1.22

What Has Changed

Date: 12/9/2013
Prior Upgrade: MediaWiki 1.20.3 Upgrade
Next Upgrade: MediaWiki 1.23.3 Upgrade
Summary of Changes:

Item	Old Version	New Version	Notes
MediaWiki	1.20.3	1.22
Variables	1.2.2	2.0.1
ConfirmEdit	1.1	1.2
InputBox	0.1.4	0.1.4	Switched to the version bundled with core. No version change.
ParserFunctions	1.1.1	1.5.1	Switched to the version bundled with core.
WikiEditor	n/a	0.3.1	Enabled the version that is bundled with core.
Vips	n/a	7.36.4	Installed from source
VipsScaler	n/a	n/a	Installed the extension. (No version #)

---

Open Issues

Toolbox

Sorry to reopen this page, but I just switched to Yuletide from Monobook for the holiday season, and my toolbox has disappeared. There's just a single link that says "toolbox". When I click it, the div expands and shows the appropriate options. Except, when it does that, it immediately redirects to a page with the words [object Object]. -Oldpinebox^Talk 18:23, 22 December 2013 (EST)

Closed Issues

Sprites

Template:Track sprites are messed up (see Lincoln#Track listing). Apollo (colloquia!) 15:23, 9 December 2013 (EST)

BW - It was displaying the first item, but then escaping all subsequent embedded html. I had to add 'img' to $htmlnest in Sanitizer. That fixed it.

Shows Pages

The Shows page is totally dead - big long error message and nothing else. BlueCanary (talk) 15:32, 9 December 2013 (EST)

BW - I moved us to the bundled version of ParserFunctions. That fixed the shows page, but let's see if it broke other things. Duke33

Toolbar

The toolbar is not visible when editing a page. (Duke33)

Well, i completely cheated on this one. I installed WikiEditor (which I was meaning to do anyway) and lo and behold, it fixed the issue completely! --Duke33 20:25, 9 December 2013 (EST)

Pre

Templates using pre tags (Template:Lyrics, Template:Tab) with noinclude tags inside the tags (?) are messed up in all kinds of ways. Apollo (colloquia!) 15:17, 9 December 2013 (EST)

BW - I've temporarily converted the Lyrics from a pre to use a div instead. Let me know if you see issues.

content was displaying as {{{1}}} rather than whatever the first parameter was equal to so made the default blank ({{{1|}}}), which fixed it for some reason? unless it was already fixed and i just needed to refresh my cache. anyway, line heights are looking a little weird. i'm guessing that's just the div styling. Apollo (colloquia!) 16:51, 9 December 2013 (EST)

I converted both to use the #tag parser function, and removed the noincludes. That seems to have fixed the issue. Here are the changes to Lyrics and Tab. --Duke33 22:00, 9 December 2013 (EST)

HTML and wikicode in lyrics (and perhaps tabs, though I haven't see any instances of it) are just displaying as plain text. (example) ~ veggieman 01:05, 16 December 2013 (EST)

I fixed this by changing us from "pre" tags to divs. -- Duke33

"view" tabs at top in Monobook

It might be just while the notice of the upgrade is visible, but on most pages the tabs across the top (article, discussion, edit, history, etc.) are barely visible above the border over the top of the notice. If you poke the mouse pointer in the tiny sliver that is visible, the text appears and you can click on it. Interestingly, that problem is not appearing on this page as I edit this. -- CJSF (talk) 16:32, 9 December 2013 (EST)

there are a lot of style issues with monobook, specifically with section headings and nav stuff; i think mr. geth and brad have enumerated them. Apollo (colloquia!) 16:43, 9 December 2013 (EST)

I am not seeing this issue any longer. -- CJSF (talk) 09:16, 10 December 2013 (EST)

Not sure, but this was probably a browser caching issue. --Duke33 10:50, 10 December 2013 (EST)

Table of Contents

Tables of Contents have two style issues:

1. They extend the entire width of the content.
2. They are missing the "hide" tags.

item #1 was happening in monobook earlier, but then it stopped. Apollo (colloquia!) 19:00, 9 December 2013 (EST)

Jon gave me some updated css, and we fixed the first part. --Duke33 10:50, 10 December 2013 (EST)

Fixed, by moving "bottomscripts" code to the actual bottom in Azure.php. --Duke33 13:29, 10 December 2013 (EST)

Bottom Scripts

1. What do you know? Enhanced Recent Changes broke again. I added some styling to core.css, but that has not fully solved the issue. --Duke33 20:46, 9 December 2013 (EST)
2. Another one that has broken several times. The preferences page shows as one big list, as opposed to individual tabs. --Duke33 12:18, 10 December 2013 (EST)

I fixed both by moving the "bottomscripts" to the bottom in Azure.php. This fixed the TOC issue above as well. --Duke33 13:29, 10 December 2013 (EST)

Search Suggestions

Don't appear to work any more. (Nehushtan)

i'm not having this problem... Apollo (colloquia!) 15:23, 9 December 2013 (EST)

Appears to be busted in Azure but working in Monobook. BlueCanary (talk) 15:35, 9 December 2013 (EST)

Works in Azure for me. What are you typing in? Duke33

fwiw, the 1.20.3 case-sensitivity bug has carried over. Apollo (colloquia!) 16:26, 9 December 2013 (EST)

It's not a bug, according to how MediaWiki works. They expect case sensitivity. Bummer. Duke33

that's too bad! is there some way around it? it doesn't happen on Wikipedia, for instance. Apollo (colloquia!) 16:40, 9 December 2013 (EST)

Search is working now, btw. Definitely wasn't before, no matter what was typed. *shrug* BlueCanary (talk) 16:46, 9 December 2013 (EST)

It's page-specific for me. On the main page, I type p in the search box and no suggestions appear.... but on this page it's perfect. (Nehushtan)

Funny now it doesn't even work here any more... grrr... (Nehushtan)

I moved this one back up because it does seem to be page specific. I just got it to work on the Main Page, but none of the other pages I tried after that. And when I first tested it, it worked on this page once, but then I couldn't get it to work again. Weird. BlueCanary (talk) 00:59, 10 December 2013 (EST)

not getting this problem in azure or monobook on any page, logged in or logged out. i just tried in IE and it didn't seem to work there, but chrome and opera (next) work fine. are you guys using firefox? Apollo (colloquia!) 09:07, 10 December 2013 (EST)

I'm on Safari. Though, once again, it seems to be working on every page I've tested it on. Cross your fingers it stays that way! BlueCanary (talk) 13:55, 10 December 2013 (EST)

Year Template

Category:Songs without Year specified, particularly odd since the other Category:Song pages that need details subcats are fine. -- 15:48, 9 December 2013 (EST)

Yes, the year template is having problems. You'll notice it on Lyrics pages as well. Duke33

I also noticed that the Year template is returning a line feed character at the end. This did not happen in 1.20.3. See this. Duke33

Jon made a fix that stripped out the line feed. He also updated the artist template.--Duke33 10:50, 10 December 2013 (EST)

Jon, can you look at Chronology:Ana Ng? The first song's Year is wrong. --Duke33 13:31, 10 December 2013 (EST)

Jon fixed it -- diff.

User Pages

User pages have stopped loading, at least on my computer. BlueCanary (talk) 15:32, 9 December 2013 (EST)

i'm getting some user pages (User:Nehushtan, User:Blitzente), not others (User:Antgeth, User:Apollo). geth reports the same thing. Apollo (colloquia!) 15:36, 9 December 2013 (EST)

apparently it extends to the same users' collections. Apollo (colloquia!) 15:40, 9 December 2013 (EST)

They do load, but they just take a LONG time. I'm not sure what's causing the issue, but I am seeing that it seems to be affected most by owners of O Tannenbaum. (Seriously). --Duke33 00:17, 10 December 2013 (EST)

For what it's worth, the issue is definitely related to collections as I just tested removing mine from my user page and it loaded just fine without it, but takes several minutes to load with it. And I don't own O Tannenbaum. BlueCanary (talk) 00:50, 10 December 2013 (EST)

I made a temporary change to the collections code. It now returns an error, until I can figure out what is wrong. I wonder if it's related to Bug #54033? --Duke33 10:50, 10 December 2013 (EST)

Special:ListFiles is broken as well. Again, this all points to issues with image thumbnailing. --Duke33 16:21, 10 December 2013 (EST)

ant's userpage is still borked and he doesn't have a collection on there, just tons of images embedded. Discography/Gallery isn't broken and neither is my sandbox, so i don't know exactly what's up there. eta: nvm, for listfiles & ant it might just be the quantity. i just tried loading just the images of ant's page in my sandbox and it won't work. Apollo (colloquia!) 19:38, 10 December 2013 (EST)

VipsScaler to the rescue! I installed Vips and the VipsScaler extension. That fixed all issues.--Duke33 21:51, 10 December 2013 (EST)

Edit Link Styling

They changed the style for "Edit" links. I made a few changes, and it seems better. But, it's still not 100% right. --Duke33 20:27, 9 December 2013 (EST)

Good to go. --Duke33 22:01, 10 December 2013 (EST)

Show Times

The time on show pages is displaying 5 hours off (at least for me). For example, a show that was at 9:00pm is displaying "4:00pm". Can someone from another time zone (other than Eastern) tell me what the difference is for them? --Duke33 20:34, 12 December 2013 (EST)

Probably caused by the upgrade of ParserFunctions. #timel uses the local time zone, which is set to Eastern. I changed Template:Show to use #time, and added the Date parameter. That changed it so that it doesn't use local time when reformatting the date. --Duke33

Image Thumbs

image thumbnails don't load at sizes greater than 180px (check). Apollo (colloquia!) 18:32, 11 December 2013 (EST)

Thank you. I had seen some weird stuff in our error log, but i couldn't explain it. So, that helps a lot. Here's what I'm seeing:

/bin/bash: line 1: 17826 Aborted IM_CONCURRENCY='1' '/usr/local/bin/vips' 'im_shrink' '/home/tmbw/public_html/wiki/images/4/43/Lincoln.png' '/tmp/transform_46e0ac1d5f28-1.png' '2.209181912323092689e+0' '2.209181912323092689e+0' 2>&1

I'll continue to look into it. --Duke33 18:50, 11 December 2013 (EST)

Update - I turned off pretty error handling, and now I see these errors:

Error creating thumbnail: vips warning: shrink: not integer shrink factors, expect poor results (process:29971): GLib-ERROR (recursed) **: gmem.c:157: failed to allocate 2032 bytes

I made a config change to set $wgMaxShellMemory = 380072. It was previously set to 180072. I just arbitrarily picked a larger number to see what would happen. So far, it's working. Let's continue to monitor and see if that fixed things, or if it continues. --Duke33 20:19, 12 December 2013 (EST)

seems to be okay now. i did a couple tests before saving this edit; for some reason the first time i tried 220px, it threw that "GLib" error, but after trying a few other values 220px (and everything else) previewed completely normally. it may have just been some wacky fluke or a cache thing. at this point everything seems to be functional. i brought a thumb of File:Nanobots.png up to 2000px in my sandbox and it previewed and saved normally, so if anything the size threshold is definitely no longer a problem! Apollo (colloquia!) 22:26, 12 December 2013 (EST)

I had to bump up the value again, because we were still seeing the error in a few places. I haven't seen the error occur in the last five hours, so I'm going to mark this as closed. --Duke33 12:38, 13 December 2013 (EST)