This Might Be A Wiki:MediaWiki 1.17 Upgrade

From This Might Be A Wiki

Use this page to report issues associated with the upgrade of the wiki software from 1.15.1 to 1.17.

What Has Changed[edit]

Date: 8/16/2011
Prior Upgrade: MediaWiki 1.15.1 Migration Issue Tracker Page
Next Upgrade: New Server (3-19-2013) Migration Issue Tracker Page
Summary of Changes:

Item Old Version New Version Notes
MediaWiki 1.15.1 1.17
ConfirmEdit Unknown 1.10 Upgraded.
InputBox Unknown Unknown Upgraded.
PHP Unknown 5.3.6 Upgraded.

Open Issues[edit]

CSS Styling Issues[edit]

  • The height needs to be adjusted on Sitenotice.

Special:ListFiles[edit]

On Special:ListFiles, I get a memory error if I try to see more than 100 files: «Fatal error: Allowed memory size of 83886080 bytes exhausted (tried to allocate 27000000 bytes) in /home/tmbwnet/public_html/wiki/includes/media/Bitmap.php on line 362». Thanks, 93.32.191.78 14:48, 25 August 2011 (EDT)

That's because they now show thumbnails. I'll see if there's anything i can configure on this. --Duke33 09:33, 26 August 2011 (EDT)
Update -- It's failing on this image

Closed Issues[edit]

Error: String exceeds 1,000 character limit[edit]

  • Almost all tabs are broken.
  • Image thumbs on song pages do not appear.
  • Fields besides "#" and "Title" in album tracklistings are broken.
  • Solution: Edited ParserFunctions.php directly, and changed $wgPFStringLengthLimit = 10000; (It was set to 1000 before)

StringFunctions[edit]

  • Solution To All: In the interim, I have rolled back to the last version of parserfunctions and stringfunctions.

Links Can't be Clicked[edit]

For some reason, in 1.17, it doesn't like relative links. Changing to an absolute link fixes the problem. IE - instead of "/wiki...", point it to "http://tmbw.net/wiki".

  • The links in Alphabetical Nav can't be clicked.
  • First played links on song pages.
  • "City" links on Shows / "Wikians Attending" on Upcoming Shows.
  • Collection log displays raw html hrefs. (Needs absolute links).
  • Lyrics, Downloads, and Tabs are not displaying in the Track listing of albums.
  • Solution: The reason behind these was that there is a new bit of code in Sanitizer.php that intentionally stops relative links from working. I commented this out, and it will need to always be commented out in future upgrades.

Resource Loading[edit]

Mediawiki made a core change to how javascript and css are loaded. Changes need to be made to all of our skins, to ensure js and css load properly. Here are some known side effects:

  • Search suggestions aren't coming up.
  • Clicking the "check all"/"check none" buttons on the advanced search page yields no result.
  • Collapsing/expanding on Recent Changes doesn't work.
  • The personal menu is not collapsed upon page load.
  • Pages are throwing this javascript error:

Error: $(el).setStyle is not a function Source File: http://tmbw.net/wiki/skins/azure/_js/moo.js Line: 2

Solution:
  1. - Removed link to wikibits.js
  2. - Added <?php $this->html('bottomscripts'); /* JS call to runBodyOnloadHook */ ?>
  3. - More info: http://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_%28users%29#Ready.2C_onload.2C_hook
  4. - Moved moo.js and personal.js to the end, so that they execute after the other scripts have loaded.
  5. - Updated in all of our custom skins

Sortable Tables[edit]

The new Resource Loader is loading overriding our custom-made table sorting, with MediaWiki's ugly table sorting.

  • Solution: This one was kind of tricky. The new /common/wikibits.js file was overriding tmbw's homegrown sorting, because the two were both looking for a table class called "sortable". I updated our sorttable.js file to look for "tmbwSortable". I also updated the name of a function in the file that was conflicting with another function in wikibits. Lastly, I then updated the class name in our pages.

CSS Styling Issues[edit]

  1. Recent Changes is showing the briefcase "Category" icon. Other pages without categories do as well. (Solution: Added this styling to Azure.css: .mw-hidden-cats-hidden{display:none}.catlinks-allhidden{display:none})
  2. Galleries have no styling. Example: Don't Let's Start (LP). (Solution: Galleries are now returned in "ul" tags, instead of "table". Updated the gallery styles in core.css. Not wild about it, but it'll do for now.)
  3. Styling needed on search results: [1] (Solution: Copied over some monobook search styling to Mediawiki:Common.css)
  4. In monobook in Safari 5, the search box inexplicably has round caps.
    • On Special:Preferences, the "save" button needs to be adjusted. (Solution: Removed "padding-top: 2em;" on #prefcontrol in core.css)
  5. Background on every other row on release details dropdowns are transparent.
  • I don't see this one. Can you provide browser, skin, examples, etc? --Duke33 09:02, 19 August 2011 (EDT)
  • Ant was experiencing this in Mb--but his interpretation of the problem was incorrect. The alternate rows in release details have always been transparent, however a white background was coming through behind the transparent rows previously in Mb. MediaWiki removed the Monobook CSS to make all tables have a white background, so I added it back in. -CapitalQ ♫ talk ♪ 10:32, 19 August 2011 (EDT)

HTML Entities[edit]

1 - Ampersands are causing the title to show incorrectly. For example, D & W shows as "D &amp; W".

  • Solution: Edited the skins directly, and changed the page title display to use $this->data['title']. Note, as a side effect, I also added logic to hide the page title on Main Page.

2 - Every guitar, bass, and drum tab has a string of characters, }&#12, tacked onto the end.

  • Solution: Edited Template:Tab, and changed it to chop off the last 13 chars. It was set to 2.

3 - On some show pages, the city was showing up like this: "in Princeton, NJ}} {{Show".

  • Solution: Jon edited Template:Show Page to look for the html entities for end curly brackets.

Special:ListFiles[edit]

Special:ListFiles was throwing errors, that it could not create thumbs. - 93.32.186.99 04:47, 22 August 2011 (EDT)

  • Solution: Did a "chown nobody:nobody * -R" on the images directory. That solved it.

File Cache[edit]

Our homegrown file cache script has the following issues with the copies of pages that it stores:

  1. The right-hand tabs are showing "Special", and it links to the actual script, not the correct page.
  2. When run by an admin directly, it is saving that admin's information in the "Personal Tools" dropdown.
Solution: I changed the script to unset the user, which solved the problem when the admin runs the script. Also, I changed the method used to create the new article. That fixed the issue with the side navigation.

PHP Warning[edit]

I was perusing the logs today and found this in the error.log. It's happening very frequently: [Tue Aug 23 23:57:24 2011] [error] [client ...] PHP Warning: filemtime() [<a href='function.filemtime'>function.filemtime</a>]: stat failed for .../public_html/wiki/skins/modern/print.css in /home/tmbwnet/public_html/wiki/includes/resourceloader/ResourceLoaderFileModule.php on line 363, referer: http://tmbw.net/wiki/Main_Page It also happens with /modern/main.css, /chick/main.css, and /simple/main.css

  • Solution: This is actually a MediaWiki bug. I had previously deleted those files, since we don't use those skins. See here for more info. In the meantime, I created dummy directories and files, to prevent that error from occurring. Will move the real files over, and according to MediaWiki, we shouldn't delete them ever.

MessageCache[edit]

On show attendance pages (for example), the title is "<showsbyuser>". Here is a thoughtful pngLink Removed to illustrate the point. There's a similar sort of thing going on with the song ratings breakdowns and overall ratings pages, and possibly others too. -Apollo (colloquia!) 14:08, 23 August 2011 (EDT)

Arguably even more thoughtful than the last. -Apollo (colloquia!) 23:44, 23 August 2011 (EDT)
That's bizarre...and I can't explain it. I know the cause and the solution. They deprecated the ability to add messages directly from the extension. So, we just need to create MediaWiki pages for those messages, and remove the messages from the code. I will update it later. I'm still not sure why it works for some, and not for others. --Duke33 09:17, 24 August 2011 (EDT)
Hey Apollo. Just out of curiosity, what do you have your language set to, on your preferences? --Duke33 15:11, 25 August 2011 (EDT)
I had it set to British English! I just tried out both pages with the language set to plain English and the titles are loading properly this way. -Apollo (colloquia!) 15:16, 25 August 2011 (EDT)
I edited all of the extensions to stop adding messages through $wgMessageCache->addMessage() calls. I then added the messages directly as wiki pages. --Duke33 13:09, 27 August 2011 (EDT)

TMBG Auctions on eBay[edit]

The end date shows as "End Date: January 1 1970 12:00:00am" for users whose time zone preference is set to "Use server default". It works properly for those users who have one set. Found by User:Apollo.

Fixed. Had to edit the extension directly. --Duke33 23:18, 31 August 2011 (EDT)


AjaxDispatcher.php Warning[edit]

[Wed Aug 24 00:01:10 2011] [error] [client ...] PHP Warning: call_user_func_array() expects parameter 2 to be array, string given in ... /public_html/wiki/includes/AjaxDispatcher.php on line 103

Solution: Dug into it some more, and found that this was happening on our shows feeds. I changed the "rsargs" parameter in the urls to "rsargs[]", and that fixed the issue. --Duke33 09:02, 1 September 2011 (EDT)

To-Do Items[edit]

  • Caching updates:
  • Investigate DBA
Retrieved from "https://tmbw.net/wiki/index.php?title=This_Might_Be_A_Wiki:MediaWiki_1.17_Upgrade&oldid=281690"